Bug Fix Windows: Remove lmdb files when delete_library is called
#1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poodlewars
reviewed
Mar 19, 2024
|
Have you done a bit of manual testing? Can we still create an lmdb library, closed the python interpreter and have that library still readable? Want to be sure we aren't deleting anything inadvertently. Our CI tests probably wouldn't catch it as they all deliberately delete the LMDB database at the end anyway! |
poodlewars
approved these changes
Mar 19, 2024
Yes, I have tested that and lmdb library isn't unexpectedly deleted if we close the interpreter. |
grusev
pushed a commit
that referenced
this pull request
Nov 25, 2024
…1437) #### Reference Issues/PRs Fixes #1266. The cause of this error was that `LmdbStorage` member `env_` keeps a handle open to the files and windows doesn't delete files if they have been opened by another process. The previous fix was attempting to do `del lib` in python and assuming that this would automatically call the `LmdbStorage` destructor and remove the `env_` handle. `del lib` doesn't guarantee immediate deletion of the library. Therefore on windows delete_library doesn't work as other lmdb has opened the files. #### What does this implement or fix? The fix moves the file removal logic in `LmdbStorage` by adding a new function `close`. The lmdb env handle is closed and this ensures no process has opened the lmdb files, so they are safe to delete. #### Any other comments? #### Checklist <details> <summary> Checklist for code changes... </summary> - [ ] Have you updated the relevant docstrings, documentation and copyright notice? - [ ] Is this contribution tested against [all ArcticDB's features](../docs/mkdocs/docs/technical/contributing.md)? - [ ] Do all exceptions introduced raise appropriate [error messages](https://docs.arcticdb.io/error_messages/)? - [ ] Are API changes highlighted in the PR description? - [x] Is the PR labelled as enhancement or bug so it appears in autogenerated release notes? </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #1266. The cause of this error was that
LmdbStoragememberenv_keeps a handle open to the files and windows doesn't delete files if they have been opened by another process. The previous fix was attempting to dodel libin python and assuming that this would automatically call theLmdbStoragedestructor and remove theenv_handle.del libdoesn't guarantee immediate deletion of the library. Therefore on windows delete_library doesn't work as other lmdb has opened the files.What does this implement or fix?
The fix moves the file removal logic in
LmdbStorageby adding a new functionclose. The lmdb env handle is closed and this ensures no process has opened the lmdb files, so they are safe to delete.Any other comments?
Checklist
Checklist for code changes...